Refactoring Issues

  • General
    • Views: ViewID and reference to class necessary?
    • System.outs which are probably not necessary any more ("XY created")
  • AnnotationBrowserWidget
    • TODO: listeners for search panel
    • method setViewer? (viewer is created internally...)
    • AnnotationEditorWidget as input: list of styles instead?
    • LabelProvider
      • Name (content?)
      • GC (Constructor/dispose but ALSO created for each image)
  • AnnotationBrowserView
    • method initTypes
      • store TypeSystem in variable (=> other lines shorter)
      • use list for calling activateJoniTypes (<= could be renamed)
  • appDelegation
    • IAnnotationEditorDialog (not sure what this is / there could be something similar in swt already...)
    • IPerspectiveDecoupledPart: name (IPerspectiveCoupledPart?)
    • ApplicationManager: subscribingset appears to be a duplicate of a list in the broker
    • ApplicationUtil
      • method urlToFile never used
  • Editor

    • package name part.editor/widget.editor: not editor.part/widget?

    • remove TestParts?

    • DeserializeXMIHandler: maybe move method createCas

    • IDFilter

      • what is setAnnotations supposed to to?
      • filterActive?

    • NameFilter

      • contains faster than regex?
      • some lines are duplicated

    • AnnotationStyleEditingDialog

      • MouseListener: TODO done?; other method than computing column widths?
      • name (editing appears to be done elsewhere)
      • getSelectionAdapter -> createSelectionAdapter

    • EditorDoubleClickDialog: rename to "Feature Assigning Dialog" (shell title)?

    • EditorPreferencesDialog

      • Button usedefault: TODO

    • LayerEditingSupport: casting without check

    • SearchDialog

      • addFindListener: only one listener -> setFindListener
      • findButton message "cannot find stuff"

    • StyleChangingDialog

      • TODO integrate other Styles to be selectable
      • Layout (a lot of composites)

    • UIMAFeatureChangeComposite

      • GridLayout with three elements but only two created
      • a table could be used here

    • AEditorSubordinateViewPart

      • TODOs
      • standard(un)subscribefrom/to... -> (un)subscribefrom/tostandard...

    • ARightViewTablePart

      • access modifiers of partService and others?; some static which are not static in AEditorSubordinateViewPart
      • column creation: column index never used
      • getSelectionAdapter -> createSelectionAdapter

    • TableColumnStruct: feat/col -> feature/column

    • EditorWidget

      • surpressAnnotation -> unsurpress or setAnnotationSurpressed
      • DEFAULT_COLOR not disposed (probably not necessary)
      • MouseMovedListener: isLeft/RightBorder independent of annotations -> do it once before isHovered is called
      • PaintListener: check time before creating runnable
      • CaretListener/WidgetSelectionListener: fireEvent vs method that calls fireEvent
      • editorListener: name suggests there is only one
      • fsSelectionChanged(): deprecated, does nothing, used once
      • add new convenience method createAnnotation?
      • changeAnnotations(): listeners do not know that other annotations beside the first one were changed
      • annotationAdded/Removed/visibilityChanged etc: change to private
      • initializeMenu2() never used
      • getSelectionOfVisibleAnnotations() -> getVisibleAnnotations() (can invisible annotations even be selected?)

    • EEditorEvent: separate entries by newlines

      • spelling: EEditorEvent.EDITOR_STYLE_CHANEGD

    • IAnnotationEditorListener: change to protected interface to force views to use the bus system?

  • //TODO
  • IeView
    • classHierarchy composite
      • spelling (hierarchie)
      • Edit Dialog: Pressing Enter key in the Textfield closes dialog instead of adding annotation; TextField not cleared when adding annotation; no way to remove entries via mouse
  • de.uniwue.mk.kall.ie.terminology
    • OWLUtil
      • annotation methods use OWLOntology <=> class methods use IEOntology